Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Only add delay when loading fisrt set of books #176

Merged
merged 1 commit into from
May 20, 2024
Merged

perf: Only add delay when loading fisrt set of books #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/src/main/java/com/starry/myne/ui/screens/home/viewmodels/HomeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ class HomeViewModel @Inject constructor(
allBooksState = allBooksState.copy(isLoading = it)
}, onRequest = { nextPage ->
try {
// Slight delay for better UX
delay(400)
// Only add delay when loading first page to show shimmer effect
// and avoid flickering when navigating to home from welcome screen
// and immediately loading the first page.
if (nextPage == 1L) delay(400L)
bookAPI.getAllBooks(nextPage, language.value)
} catch (exc: Exception) {
Result.failure(exc)
Expand Down
Loading