Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ignore Image Files Option to UUID BCheck #229

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

alp1n3-eth
Copy link
Contributor

This is a fix in reference to the following issue: #193

I've added the configuration option to ignore the content-types related to the following image files: gif, png, jpeg, svg+xml. More can be added, in original issue request they reference it hitting on .exe files, but I could only find files with valid FP hits for the above extensions and not an .exe. If needed, I can throw that check in there as well, but I wanted to keep this as "realistic" as possible and only added checks for FP hits that I observed and could therefore test against.

BCheck Contributions

  • BCheck compiles and executes as expected
  • BCheck contains appropriate metadata (name, version, author, description and appropriate tags)
  • Only .bcheck files have been added or modified
  • BCheck is in the appropriate folder
  • PR contains single or limited number of BChecks (Multiple PRs are preferred)
  • BCheck attempts to minimize false positives

Added the configuration option to ignore the content-types related to the following image files: gif, png, jpeg, svg+xml.
@alp1n3-eth alp1n3-eth changed the title Added Ignore Image Files Option Added Ignore Image Files Option to UUID BCheck Sep 14, 2024
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Many thanks for contributing to this BCheck :)

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your PR! It's great to see one of the template bugs addressed.

@PortSwiggerWiener PortSwiggerWiener merged commit 26bdcc5 into PortSwigger:main Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants