Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create HighlightTrackerServices.bambda #49

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Create HighlightTrackerServices.bambda #49

merged 4 commits into from
Dec 20, 2023

Conversation

BugBountyzip
Copy link
Contributor

@BugBountyzip BugBountyzip commented Dec 18, 2023 •
edited
Loading

Ever feel like you're being followed online? WhoSpyOnMe is here to confirm your suspicions!

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

@BugBountyzip
Create WhoSpyOnMe?.bambda
29f12f9 
Ever feel like you're being followed online? WhoSpyOnMe is here to confirm your suspicions!
PortSwiggerWiener
PortSwiggerWiener requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. I've added some comments.

Please can you also rename this to be more descriptive. Ideally it would explain the function of the bambda without requiring the code to be read.

Proxy/HTTP/WhoSpyOnMe?.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/WhoSpyOnMe?.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/WhoSpyOnMe?.bambda Outdated Show resolved Hide resolved
@BugBountyzip
Update WhoSpyOnMe?.bambda
5e37fe8 
Updating the author format

Removing the unnecessary check for response existence, as it's not used in the logic.

Removing the check for URL existence in the request, as it's likely always present in a valid HTTP request.
@BugBountyzip
Rename WhoSpyOnMe?.bambda to HighlightTrackerServices.bambda
3cf7161
@BugBountyzip BugBountyzip changed the title Create WhoSpyOnMe?.bambda Create HighlightTrackerServices.bambda Dec 20, 2023
@BugBountyzip
Copy link
Contributor Author

i changed the name to HighlightTrackerServices but feel free to select any name you love

PortSwiggerWiener
PortSwiggerWiener approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggested changes.

Looks good 👍

Michelle-PortSwigger
Michelle-PortSwigger approved these changes Dec 20, 2023
View reviewed changes
Copy link

@Michelle-PortSwigger Michelle-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PortSwiggerWiener PortSwiggerWiener merged commit b43d084 into PortSwigger:main Dec 20, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PortSwiggerWiener PortSwiggerWiener PortSwiggerWiener approved these changes

@Michelle-PortSwigger Michelle-PortSwigger Michelle-PortSwigger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BugBountyzip @Michelle-PortSwigger @PortSwiggerWiener