Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Column for SOAPMethods #73

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Custom Column for SOAPMethods #73

merged 1 commit into from
Apr 17, 2024

Conversation

ncoblentz
Copy link
Contributor

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

@ncoblentz
Copy link
Contributor Author

See the screenshot/comment in the WCFBinarySoapMethod pull request. I was able to run Bambda Checker successfully. Not sure of the source of the failure in the step above.

Hannah-PortSwigger
Hannah-PortSwigger approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@josh-psw josh-psw merged commit abeaea2 into PortSwigger:main Apr 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-psw josh-psw josh-psw approved these changes

@Hannah-PortSwigger Hannah-PortSwigger Hannah-PortSwigger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncoblentz @Hannah-PortSwigger @josh-psw