Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bambda for pwnfox housekeeping #80

Merged

Conversation

GangGreenTemperTatum
Copy link
Contributor

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be simplified to the following?

return request.isInScope() && request.hasHeader("X-Pwnfox-Color");

If you were interested, you could also add color highlighting to this Bambda.

@GangGreenTemperTatum
Copy link
Contributor Author

GangGreenTemperTatum commented Oct 28, 2024

Could this be simplified to the following?

return request.isInScope() && request.hasHeader("X-Pwnfox-Color");

good feedback, thanks for the sloppiness. - addressed and tested

pwnfox supports the following color schemas:

image

If you were interested, you could also add color highlighting to this Bambda.

i think this would make more sense if you were using FoxyProxy or something similar? although looking there doesn't seem to be inherited user-agent headers that distinguish it.. Effectively using something like FoxyProxy and the suggested bambda you could re-create pwnfox in an alternate engineering way.. hope that makes sense

@Hannah-PortSwigger
Copy link
Contributor

Thanks for making this change! This looks good :)

I was having a look at this reference on the PwnFox repo but after a closer read it does sound more in-depth than would be achievable with a Bambda.

@GangGreenTemperTatum
Copy link
Contributor Author

Thanks for making this change! This looks good :)

I was having a look at this reference on the PwnFox repo but after a closer read it does sound more in-depth than would be achievable with a Bambda.

agreed, thanks for the approval! :)

Copy link
Contributor

@ps-porpoise ps-porpoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ps-porpoise ps-porpoise merged commit e1154e5 into PortSwigger:main Oct 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants