Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

drop the unused site_url field #30

Merged
merged 1 commit into from
Sep 15, 2023
Merged

drop the unused site_url field #30

merged 1 commit into from
Sep 15, 2023

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Sep 15, 2023

The capture.py code indicates it's unused and vestigial, and a code search on the monolith does not return any useful use of that field. It's not in the CH schema anymore, so it's copied-over by plugin-server but dropped by CH.

@xvello xvello requested a review from ellie September 15, 2023 10:58
@xvello xvello marked this pull request as ready for review September 15, 2023 10:58
@xvello xvello merged commit 9ad1d64 into main Sep 15, 2023
4 checks passed
@xvello xvello deleted the xvello/site_url branch September 15, 2023 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants