Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

tracing: add ack_wait spans #60

Merged
merged 2 commits into from
Nov 28, 2023
Merged

tracing: add ack_wait spans #60

merged 2 commits into from
Nov 28, 2023

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Nov 28, 2023

Latency has increased an order of magnitude with the addition of the ACK wait. While I expected some increase, I'd like to confirm whether it's the main cause of the latency. Let's add an ad-hoc span around it.

Tested locally:

image

image

@xvello xvello requested a review from ellie November 28, 2023 10:03
@ellie
Copy link
Contributor

ellie commented Nov 28, 2023

CI is very sad 😞

@xvello
Copy link
Contributor Author

xvello commented Nov 28, 2023

@ellie reworked it with proper async spans, as documented here. Should be GTG now.

@xvello xvello merged commit cd4d639 into main Nov 28, 2023
4 checks passed
@xvello xvello deleted the ack-span branch November 28, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants