This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
carve out the limiters and sinks sub-modules #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/submods
branch
from
6f33e64 to
f3e08bb
Compare
xvello
changed the title
ellie
reviewed
Dec 12, 2023
ellie
reviewed
Dec 12, 2023
xvello
commented
Dec 12, 2023
| @@ -28,8 +28,8 @@ pub static DEFAULT_CONFIG: Lazy<Config> = Lazy::new(|| Config { | |||
| print_sink: false, | |||
| address: SocketAddr::from_str("127.0.0.1:0").unwrap(), | |||
| redis_url: "redis://localhost:6379/".to_string(), | |||
| burst_limit: NonZeroU32::new(5).unwrap(), | |||
| per_second_limit: NonZeroU32::new(10).unwrap(), | |||
| overflow_burst_limit: NonZeroU32::new(5).unwrap(), | |||
There was a problem hiding this comment.
These two are not defined in the chart, safe to rename now
ellie
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate is starting to get crowded, let's start organizing the modules. No code changes except tuning the imports to match the new hierarchy.
There's touch-ups and cleanups I'd like to do next, but I'll keep this one short.