Revert "fix(nginx): set service-upstream to "true"" #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this doesn't play so well with e.g. http keepalive. Rather we want NGINX to know that a pod port has been removed from a Service Endpoint thereby being able to handle reaping these connections. As a result of using the Service, on ingress-nginx creating a connection, it is first iptable routed to a pod. After this, the connection will be maintained for 120 seconds which I think is fine as a setting fwiw.
ingress-nginx will still be sending requests down this connection, even after the pod port has been removed from the Endpoint, and getting 502 which isn't what we want.
I'm yet to test this however.
For reading material: https://learnk8s.io/kubernetes-long-lived-connections
Reverts #532