Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was trying to set up the ingress for Posthog and I saw that this option wasn´t available in the helm chart, that´s why I decided to push this PR. The ingressClassName is the recommended way to specify what Ingress controller do you want to use since Kubernetes > 1.18.
See this URL for more info
Type of change
How has this been tested?
To test this implementation I deployed locally Posthog and checked that the ingress was working fine with the new ingressClassName properly set in the ingress resource.
In case you use the annotation
kubernetes.io/ingress.class: nginx
for speciying the ingress controller that you want to use, you can delete it and add this line under ingress:ingressClassName: nginx
Checklist