-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
SO GOOD!!! 😍 |
Reminder to me to merge into PostHog/posthog-js#801 when this PR is ready to go |
I added some fixes! Everything else looks super awesome. Just two things
![]()
![]() |
Just a heads up @smallbrownbike, @neilkakkar is moving the code over on Monday to For more context: We're migrating the site off plugins and into LMK if you've got any questions |
I think multiple choice vs single choice should be clearer, the convention here is radio buttons vs square buttons. Because you could have a single choice survey with multiple answers to choose from. |
Looks amazing already though! |
|
I had thought about this but am not overly concerned about it given:
I think in the future, as we allow more question types, multiple questions, and steps, we can think through this a bit more. |
@smallbrownbike This is so petty but can we thicken the selected borders? I think I used 1.5px in the mocks. Just accentuates them a bit. (2px felt too heavy) |
Can we make the thank you box auto close after 3 seconds or something if a user hasn’t closed it themselves? 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment above, but this is good to go otherwise I think! Awesome changes
Not a huge fan of this idea (we have the PostHog logo in there people can click on, and you could theoretically add a link to the description) but would be okay doing this if we had a progress bar counting down to it closing, or the button counting it down like |
* support multiple questions * disable next and submit buttons if no response in survey question * fix * change response syntax
Updates the UI on all survey types to match these designs.
Things to note
ratingButtonHoverColor
in favor ofratingButtonActiveColor
(since there is a submit button on all surveys, the active color indicates which rating is selected before the user clicks submit)