This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
common: refactor health into its own lib crate #23
+79
−389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As more services will be added to the repo, we should have a story around code sharing. This PR uses the
health
module as a proposition for that code sharing topology. Let's:common
crate: should help avoid side-effects and keep compilation parallelism higherpath
referenceph-
prefix all internal crate names to easily differentiate themI also sorted the
Cargo.toml
files while I was shuffling stuff around. Overall, this should be a no-op PR.