This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Make max_body_size configurable via env, drop custom check, use 413 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
force-pushed
the
brett/max_body_size
branch
from
1435e42 to
1ed0af5
Compare
bretthoerner
commented
May 3, 2024
| @@ -16,6 +16,9 @@ pub struct Config { | |||
|
|
|||
| #[envconfig(default = "100")] | |||
| pub max_pg_connections: u32, | |||
|
|
|||
| #[envconfig(default = "5000000")] | |||
There was a problem hiding this comment.
I tried, but this doesn't support anything but a plain number (i.e. no 5_000_000)
xvello
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know Axum had its own default limit until today, this cleans up the hack made here cf9b82d and leans into their limiter and makes it more easily configurable.