This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Add histogram for insertion time to completion time #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
force-pushed
the
brett/insert-to-complete-metric
branch
from
a8ca222 to
621df0f
Compare
xvello
reviewed
Feb 7, 2024
tomasfarias
reviewed
Feb 7, 2024
|
Thanks, handled both items of feedback (and the repo builds work now). |
xvello
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from old repo.
This repo is now configured like
rusty-hook(i.e. same branch protection and merge requirements)Currently using the pre-existing buildjet config because I want to see everything work like it used to before changing anything.
Note that I added a
hog-rsprefix to the images that will be built, i.e. ghcr.io/posthog/hog-rs/capture instead of ghcr.io/posthog/captureThis is so nothing from this repo goes to prod until we're ready. We can either remove the prefix, or keep and it change charts. I kind of like having it, because if I just saw the image name I'd have an easier time finding the repo. 🤷♂️