Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dispose recorder if masking is disabled #166

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: dispose recorder if masking is disabled #166

wants to merge 6 commits into from
+60 −29

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 28, 2025 •
edited
Loading

💡 Motivation and Context

Relates to #142

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

marandaneto
marandaneto commented Feb 28, 2025
View reviewed changes
lib/src/replay/screenshot/screenshot_capturer.dart
shouldSendMetaEvent: shouldSendMetaEvent);
completer.complete(imageInfo);
} finally {
picture.dispose();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was missing here

@marandaneto marandaneto requested review from ioannisj and a team February 28, 2025 09:07
@marandaneto marandaneto mentioned this pull request Feb 28, 2025
Open
pauldambra
pauldambra approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

ioannisj
ioannisj approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto requested a review from ioannisj February 28, 2025 12:46
@marandaneto
Copy link
Member Author

@ioannisj can you double check? there were more changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

@ioannisj ioannisj Awaiting requested review from ioannisj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @pauldambra @ioannisj