Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xcframework builds #288

Merged
merged 6 commits into from
Jan 28, 2025
Merged

fix: xcframework builds #288

merged 6 commits into from
Jan 28, 2025

Conversation

ioannisj
Copy link
Contributor

💡 Motivation and Context

see: https://posthog.slack.com/archives/C06GCP04DT7/p1737633958220259

The way we were importing phlibwebp caused it to be exposed in the .swiftinterface of the PostHog library. This unintended exposure occurred because phlibwebp was included as a public dependency (currently default) in code, which made its symbols visible outside of the library. In turn, this became a build issue when building an xcframework since usually frameworks are archived using the BUILD_LIBRARY_FOR_DISTRIBUTION=YES for module stability.

To resolve this, the import of phlibwebp was made internal which ensures it does not leak into the public interface of the library.

#skip-changelog

💚 How did you test it?

  • Confirmed successful builds using a new xcframework sample project.
  • xcframework flow (archive -> create xcframework -> embed in client app) is now tested as part of make buildExamples

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from marandaneto as a code owner January 28, 2025 13:45
@ioannisj ioannisj requested a review from a team January 28, 2025 13:45
@marandaneto
Copy link
Member

Probably deserves a changelog entry?

@ioannisj ioannisj merged commit 75a686f into main Jan 28, 2025
6 checks passed
@ioannisj ioannisj deleted the fix/internal-phlibwebp branch January 28, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants