Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
see: https://posthog.slack.com/archives/C06GCP04DT7/p1737633958220259
The way we were importing
phlibwebp
caused it to be exposed in the .swiftinterface of the PostHog library. This unintended exposure occurred becausephlibwebp
was included as a public dependency (currently default) in code, which made its symbols visible outside of the library. In turn, this became a build issue when building an xcframework since usually frameworks are archived using theBUILD_LIBRARY_FOR_DISTRIBUTION=YES
for module stability.To resolve this, the import of
phlibwebp
was made internal which ensures it does not leak into the public interface of the library.#skip-changelog
💚 How did you test it?
make buildExamples
📝 Checklist