Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not rely on timer for session replay active check #297

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix: do not rely on timer for session replay active check #297

merged 2 commits into from
Feb 11, 2025

Conversation

ioannisj
Copy link
Contributor

💡 Motivation and Context

Closes PostHog/posthog-flutter#160

Do not rely on timer property (since it's conditionally set for Flutter SDK)

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from a team February 11, 2025 07:09
@ioannisj ioannisj merged commit 9bcf759 into main Feb 11, 2025
6 checks passed
@ioannisj ioannisj deleted the fix/flutter-session-recordings branch February 11, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS Mobile Session Replay Blank Screen
2 participants
@ioannisj @marandaneto