-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make password capture more explicit #1345
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +244 B (+0.02%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
On Mobile, for certain types of views such as for sure containing PII data (password/email, etc), it's not possible to disable the masking, see https://posthog.com/docs/session-replay/ios#masking-in-swiftui |
If people can do |
Changes
Since #1334 we mask passwords by default.
I want to take this a step further and always include password input masking unless it is explicitly opted out using the
dangerouslyCapturePasswordInputs
. While I can't see any reasonably good reason that you'd want to unmask a password input, we should still allow it if someone is certain that's what they want to do. It will be slightly more difficult / confusing to configure but that feels like a worthy trade-off to avoid customers accidentally unmasking password inputs by leaving thepassword: true
field out of theirmaskInputOptions
config