Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip rate limiting of snapshot events #1383

Merged
merged 4 commits into from
Aug 27, 2024
Merged

chore: skip rate limiting of snapshot events #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
214733b
chore: check rate limit outside of capture method
daibhin Aug 23, 2024
7e80797
add test
daibhin Aug 23, 2024
e4cd73d
Merge branch 'main' into dn-chore/check-rate-limit-outside-capture
daibhin Aug 27, 2024
c24a107
simplify to skip_client_rate_limiting
daibhin Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/__tests__/extensions/replay/sessionrecording.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,7 @@ describe('SessionRecording', () => {
_url: 'https://test.com/s/',
_noTruncate: true,
_batchKey: 'recordings',
skip_client_rate_limiting: true,
}
)
})
Expand Down Expand Up @@ -767,6 +768,7 @@ describe('SessionRecording', () => {
_url: 'https://test.com/s/',
_noTruncate: true,
_batchKey: 'recordings',
skip_client_rate_limiting: true,
}
)
})
Expand Down Expand Up @@ -849,6 +851,7 @@ describe('SessionRecording', () => {
_url: 'https://test.com/s/',
_noTruncate: true,
_batchKey: 'recordings',
skip_client_rate_limiting: true,
}
)

Expand Down Expand Up @@ -1514,6 +1517,7 @@ describe('SessionRecording', () => {
_batchKey: 'recordings',
_noTruncate: true,
_url: 'https://test.com/s/',
skip_client_rate_limiting: true,
}
)

Expand Down Expand Up @@ -1607,6 +1611,7 @@ describe('SessionRecording', () => {
_batchKey: 'recordings',
_noTruncate: true,
_url: 'https://test.com/s/',
skip_client_rate_limiting: true,
}
)

Expand Down Expand Up @@ -1635,6 +1640,7 @@ describe('SessionRecording', () => {
_batchKey: 'recordings',
_noTruncate: true,
_url: 'https://test.com/s/',
skip_client_rate_limiting: true,
}
)
expect(sessionRecording['buffer']).toEqual({
Expand Down
1 change: 1 addition & 0 deletions src/extensions/replay/sessionrecording.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,7 @@ export class SessionRecording {
_url: this.instance.requestRouter.endpointFor('api', this._endpoint),
_noTruncate: true,
_batchKey: SESSION_RECORDING_BATCH_KEY,
skip_client_rate_limiting: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the short term i think we should just get this line in

i can't think of a problem caused by volume of snapshots that wasn't from a pre-batching version of the SDK

so i think we can skip client rate limiting for replay and then figure out a good solution with the pressure off

})
}

Expand Down
Loading