Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: captured network requests must always have name property #1398

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Sep 3, 2024

v1.160.2 introduced much more robust network capture... too robust because now we can capture requests without their URL. no bueno

let's always capture the URL so that if there is no performance entry we at least have that url

(for the benefit of the future traveller... the requests captured without a URL are requests that we previously couldn't capture at all)

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Sep 3, 2024 2:57pm

@pauldambra pauldambra requested a review from a team September 3, 2024 14:56
@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Size Change: +123 B (+0.01%)

Total Size: 1.18 MB

Filename Size Change
dist/array.full.js 336 kB +41 B (+0.01%)
dist/recorder-v2.js 110 kB +41 B (+0.04%)
dist/recorder.js 111 kB +41 B (+0.04%)
ℹ️ View Unchanged
Filename Size
dist/array.js 156 kB
dist/exception-autocapture.js 10.4 kB
dist/main.js 157 kB
dist/module.js 156 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@marandaneto
Copy link
Member

we can capture requests without their URL. no bueno

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants