feat(experiments): Apply no-code experiments to the webpage. #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Phanatic
changed the title
|
Size Change: +19.8 kB (+1.67%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
dmarticus
approved these changes
Sep 10, 2024
Comment on lines
+226
to
+244
| transform.attributes.forEach((attribute) => { | ||
| switch (attribute.name) { | ||
| case 'text': | ||
| htmlElement.innerText = attribute.value | ||
| break | ||
|
|
||
| case 'html': | ||
| htmlElement.innerHTML = attribute.value | ||
| break | ||
|
|
||
| case 'cssClass': | ||
| htmlElement.className = attribute.value | ||
| break | ||
|
|
||
| default: | ||
| htmlElement.setAttribute(attribute.name, attribute.value) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
obviously users won't try to do this, and it's possible we're making this impossible on the server side, but should we sanitize the contents of these values that we're setting onto the DOM?
There was a problem hiding this comment.
good idea about sanitizing payload. We can do that on the server-side with nh like we do for survey HTML
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a new extension to posthog-js called
web-experimentswhich allows posthog to apply no-code experiments to elements on a web page. This PR needs PostHog/posthog#24872 to merge so it can function.To enable this feature, developers have to opt-in by setting
disable_web_experimentsto false inposthog.initwhile in Beta.There are multiple ways to target an experiment within the browser here :
exact, contains, not_contains, regex, not_regexChecklist
Coming up in following PRs