-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bundle option without any external scripts #1413
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +2.71 kB (+0.1%) Total Size: 2.79 MB
ℹ️ View Unchanged
|
oh, well now I need to test the external scripts typing PR... that's not fair 🤣 |
…ipts-option # Conflicts: # src/utils/globals.ts
# Conflicts: # src/utils/globals.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running locally all seems good
no-external bundle excludes the remote loading code
i think we're good to go
Can we have a new release? Thank you |
+1 |
there is one, https://github.com/PostHog/posthog-js/releases/tag/v1.164.1 |
Changes
Builds on top of @pauldambra 's great external scripts typing work and makes the external deps loader a separate extension that we can then include depending on the bundle
This allows someone to import specific modules such as
Checklist
…ut it