chore: downgrade jest types #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 2.8 MB ℹ️ View Unchanged
|
pauldambra
commented
Sep 28, 2024
| @@ -1,12 +1,22 @@ | |||
| /* eslint-disable compat/compat */ | |||
| import { v4 } from 'uuid' | |||
There was a problem hiding this comment.
uuid package is incompatible in some way with jest 28+ and we don't need it, we only use it in this file, so we can uuidv7 instead
pauldambra
commented
Sep 28, 2024
Comment on lines
+6
to
+17
| async function shortWait() { | ||
| // no need to worry about ie11 compat in tests | ||
| // eslint-disable-next-line compat/compat | ||
| await new Promise<void>((resolve: () => void) => setTimeout(resolve, 500)) | ||
| } | ||
|
|
||
| describe('FunctionalTests / Feature Flags', () => { | ||
| let token: string | ||
|
|
||
| beforeEach(() => { | ||
| token = uuidv7() | ||
| }) |
There was a problem hiding this comment.
a little tidying while we're in here
pauldambra
commented
Sep 28, 2024
Comment on lines
+11
to
+19
| let token: string | ||
| let posthog: PostHog | ||
| let anonymousId: string | ||
|
|
||
| beforeEach(async () => { | ||
| token = uuidv7() | ||
| posthog = await createPosthogInstance(token) | ||
| anonymousId = posthog.get_distinct_id() | ||
| }) |
There was a problem hiding this comment.
same same, a little tidying since we're removing uuid from here
pauldambra
commented
Sep 28, 2024
| "@testing-library/preact": "^3.2.4", | ||
| "@types/eslint": "^8.44.6", | ||
| "@types/jest": "^29.5.1", | ||
| "@types/jest": "^27.5.1", |
There was a problem hiding this comment.
the fix we came here to make
pauldambra
commented
Sep 28, 2024
| "@types/web": "^0.0.154", | ||
| "@typescript-eslint/eslint-plugin": "^8.2.0", | ||
| "@typescript-eslint/parser": "^8.2.0", | ||
| "babel-eslint": "10.1.0", |
There was a problem hiding this comment.
clearly not using this
pauldambra
commented
Sep 28, 2024
| "@types/node": "^22.5.0", | ||
| "@types/react-dom": "^18.0.10", | ||
| "@types/sinon": "^17.0.1", | ||
| "@types/uuid": "^9.0.1", |
There was a problem hiding this comment.
was weird that we were importing a function from a types package anyway
oliverb123
approved these changes
Sep 28, 2024
This was referenced Oct 22, 2024
This was referenced Oct 26, 2024
This was referenced Oct 29, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have jest types v29 and jest v27
this led me down a path of confusion where the types suggested you could do something you couldn't really
trying to upgrade to jest 29 caused one of those cascading error -> upgrade -> sadness cycles
let's downgrade the types package instead