Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no need to swallow import errors #1486

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

pauldambra
Copy link
Member

i realised that we have some very specific imports for the recorder which TS doesn't like, and in the PR that introduced them (#526) we added eslint comments to swallow them

that seems unnecessary and brittle

and may relate to #1276

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 18, 2024 8:23am

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Oct 18, 2024
Copy link

Size Change: 0 B

Total Size: 2.82 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 172 kB
dist/array.full.es5.js 248 kB
dist/array.full.js 325 kB
dist/array.full.no-external.js 324 kB
dist/array.js 155 kB
dist/array.no-external.js 154 kB
dist/exception-autocapture.js 8.75 kB
dist/external-scripts-loader.js 2.19 kB
dist/main.js 156 kB
dist/module.full.js 325 kB
dist/module.full.no-external.js 324 kB
dist/module.js 155 kB
dist/module.no-external.js 154 kB
dist/recorder-v2.js 92.6 kB
dist/recorder.js 92.7 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra pauldambra merged commit b5233ef into main Oct 18, 2024
17 checks passed
@pauldambra pauldambra deleted the fix/no-need-to-swallow-errors branch October 18, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants