Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: careful now #1497

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: careful now #1497

merged 1 commit into from
Oct 25, 2024

Conversation

pauldambra
Copy link
Member

immediately after #1496

i realised that in moving to the utility function i'd missed a little bit of correctness that could creep in over time

using min seems safest if range min and max don't make sense

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 24, 2024 11:10am

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Oct 24, 2024
@pauldambra pauldambra requested a review from a team October 24, 2024 11:06
Copy link

Size Change: +535 B (+0.02%)

Total Size: 2.89 MB

Filename Size Change
dist/array.full.es5.js 248 kB +54 B (+0.02%)
dist/array.full.js 335 kB +54 B (+0.02%)
dist/array.full.no-external.js 334 kB +54 B (+0.02%)
dist/array.js 156 kB +53 B (+0.03%)
dist/array.no-external.js 155 kB +53 B (+0.03%)
dist/main.js 157 kB +53 B (+0.03%)
dist/module.full.js 335 kB +54 B (+0.02%)
dist/module.full.no-external.js 334 kB +54 B (+0.02%)
dist/module.js 156 kB +53 B (+0.03%)
dist/module.no-external.js 155 kB +53 B (+0.03%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 182 kB
dist/exception-autocapture.js 8.75 kB
dist/external-scripts-loader.js 2.19 kB
dist/recorder-v2.js 102 kB
dist/recorder.js 103 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra pauldambra removed the bump patch Bump patch version when this PR gets merged label Oct 25, 2024
@pauldambra pauldambra merged commit 3cbd118 into main Oct 25, 2024
17 checks passed
@pauldambra pauldambra deleted the fix/careful-now branch October 25, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants