Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify survey types #1590

Merged
merged 1 commit into from
Dec 10, 2024
Merged

feat: Simplify survey types #1590

merged 1 commit into from
Dec 10, 2024

Conversation

benjackwhite
Copy link
Collaborator

Changes

Changes survey action type to match here PostHog/posthog#26759

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Dec 9, 2024
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 9, 2024 5:13pm

@benjackwhite benjackwhite added bump minor Bump minor version when this PR gets merged and removed bump patch Bump patch version when this PR gets merged labels Dec 9, 2024
Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for doing this.

Copy link

github-actions bot commented Dec 9, 2024

Size Change: 0 B

Total Size: 3.21 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/array.full.es5.js 260 kB
dist/array.full.js 364 kB
dist/array.full.no-external.js 362 kB
dist/array.js 178 kB
dist/array.no-external.js 176 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/main.js 179 kB
dist/module.full.js 364 kB
dist/module.full.no-external.js 362 kB
dist/module.js 178 kB
dist/module.no-external.js 177 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@benjackwhite benjackwhite merged commit bdd6b7b into main Dec 10, 2024
16 of 20 checks passed
@benjackwhite benjackwhite deleted the fix/survey-types branch December 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants