Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flags): Re-enable reload only when request finishes #791

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix(flags): Re-enable reload only when request finishes #791

merged 2 commits into from
Sep 7, 2023

Conversation

neilkakkar
Copy link
Collaborator

Changes

Fixes #790
...

Checklist

@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

Size Change: +116 B (0%)

Total Size: 678 kB

Filename Size Change
dist/array.full.js 175 kB +29 B (0%)
dist/array.js 117 kB +29 B (0%)
dist/es.js 117 kB +29 B (0%)
dist/module.js 117 kB +29 B (0%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 93.6 kB
dist/recorder.js 58.3 kB

compressed-size-action

benjackwhite
benjackwhite approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@neilkakkar neilkakkar merged commit 1166b8c into master Sep 7, 2023
11 checks passed
@neilkakkar neilkakkar deleted the fix-reload-queue branch September 7, 2023 11:19
@neilkakkar neilkakkar mentioned this pull request Sep 14, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@mariusandra mariusandra Awaiting requested review from mariusandra

@pauldambra pauldambra Awaiting requested review from pauldambra

Assignees
No one assigned
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect feature flags if group is called very quickly after initialization
2 participants
@neilkakkar @benjackwhite