Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Relative import to fix typescript compilation #809

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

neilkakkar
Copy link
Collaborator

Changes

Fixes #807

Tested it works with the minimal reproduction here: https://github.com/pauldambra/test-posthog-import (thanks @pauldambra )

Just checking if this adversely affects the survey loader package 👀

Better alternative to #808
...

Checklist

@neilkakkar neilkakkar marked this pull request as ready for review September 26, 2023 10:36
@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Size Change: 0 B

Total Size: 709 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 119 kB
dist/es.js 118 kB
dist/module.js 119 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB
dist/surveys.js 23.6 kB

compressed-size-action

@neilkakkar neilkakkar merged commit 918cbc1 into master Sep 26, 2023
11 checks passed
@neilkakkar neilkakkar deleted the type-fix branch September 26, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot find module 'posthog-surveys-types'" with posthog-js 1.77.3 and later
2 participants