Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): fix emoji rating scale bug #887

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Nov 13, 2023

Changes

Rating type question with emoji displays were bugging out because we were only accounting for the scales for 10 and 5

Checklist

@liyiy liyiy requested a review from neilkakkar November 13, 2023 23:00
@liyiy liyiy added the bump patch Bump patch version when this PR gets merged label Nov 13, 2023
Copy link

Size Change: +20 B (0%)

Total Size: 732 kB

Filename Size Change
dist/surveys.js 39.8 kB +20 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 173 kB
dist/array.js 115 kB
dist/es.js 115 kB
dist/exception-autocapture.js 12 kB
dist/module.js 115 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.3 kB

compressed-size-action

@liyiy liyiy merged commit 724f154 into master Nov 13, 2023
16 checks passed
@liyiy liyiy deleted the fix-undefined-addeventlistener branch November 13, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant