Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: class string separator #935

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: class string separator #935

merged 1 commit into from
Dec 12, 2023

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Dec 12, 2023

Default join character in JS (it turns out 🤦) is the comma.

So, in the change to handle newlines in class strings the split string was accidentally joined with a comma instead of a space.

Frustratingly easy bug to introduce but at least now has an assertion to protect us in future

I checked old events in the explorer (pre 1.94.0) to see what format the elements string is presented in. So I think this now formats correctly

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Dec 12, 2023
Copy link

Size Change: +12 B (0%)

Total Size: 747 kB

Filename Size Change
dist/array.full.js 177 kB +3 B (0%)
dist/array.js 118 kB +3 B (0%)
dist/es.js 118 kB +3 B (0%)
dist/module.js 118 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.4 kB
dist/surveys.js 41.5 kB

compressed-size-action

@pauldambra pauldambra requested a review from a team December 12, 2023 10:25
@pauldambra pauldambra merged commit a1c5e7b into master Dec 12, 2023
16 checks passed
@pauldambra pauldambra deleted the fix/class-string branch December 12, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants