Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: survey event typo #10107

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: survey event typo #10107

merged 1 commit into from
Dec 11, 2024

Conversation

marandaneto
Copy link
Member

Changes

https://posthog.com/docs/surveys/implementing-custom-surveys#capture-survey-lifecycle-events

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Dec 11, 2024 0:06am

@marandaneto
Copy link
Member Author

@skoob13 I believe there's a typo here too https://github.com/PostHog/posthog/blob/89db0330cdb62426e4fa7d23a14dbba54cd9182f/posthog/hogql_queries/ai/event_taxonomy_query_runner.py#L88-L89
probably ctrl c ctrl v? Should I fix this as well?

@marandaneto marandaneto requested a review from skoob13 December 11, 2024 11:58
@skoob13
Copy link
Contributor

skoob13 commented Dec 11, 2024

@skoob13 I believe there's a typo here too PostHog/posthog@89db033/posthog/hogql_queries/ai/event_taxonomy_query_runner.py#L88-L89 probably ctrl c ctrl v? Should I fix this as well?

@marandaneto those are some legacy/reserved events like $survey_dismissed/name-of-the-survey. We want the "survey shown" and "survey dismissed" events to be available for the agent, so no changes are required. Thanks for pinging me!

@marandaneto marandaneto merged commit f5093d7 into master Dec 11, 2024
3 checks passed
@marandaneto marandaneto deleted the fix/survey_event_typo branch December 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants