fix: ux improvements for CSS selector field in surveys #71529
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Storybook | |
| on: | |
| pull_request: | |
| paths: # Only run if the frontend has changed | |
| - 'frontend/**' | |
| - 'ee/frontend/**' | |
| - '.storybook/**' | |
| - 'package.json' | |
| - '.github/workflows/storybook-chromatic.yml' | |
| - 'playwright.config.ts' | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |
| # This is so that the workflow run isn't canceled when a snapshot update is pushed within it by posthog-bot | |
| # We do however cancel from container-images-ci.yml if a commit is pushed by someone OTHER than posthog-bot | |
| cancel-in-progress: false | |
| jobs: | |
| storybook-chromatic: | |
| name: Publish to Chromatic | |
| runs-on: ubuntu-latest | |
| timeout-minutes: 15 | |
| # Don't run on forks | |
| if: github.event.pull_request.head.repo.full_name == github.repository | |
| outputs: | |
| storybook-url: ${{ steps.publish.outputs.storybookUrl }} | |
| steps: | |
| - uses: actions/checkout@v3 | |
| with: | |
| fetch-depth: 0 # 👈 Required to retrieve git history (https://www.chromatic.com/docs/github-actions) | |
| - name: Install pnpm | |
| uses: pnpm/action-setup@v4 | |
| - name: Set up Node.js | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: 18.12.1 | |
| cache: pnpm | |
| - name: Install dependencies and Chromatic | |
| run: | | |
| pnpm --filter=@posthog/storybook... install --frozen-lockfile | |
| bin/turbo --filter=@posthog/storybook prepare | |
| pnpm install -w -D chromatic | |
| - name: Publish to Chromatic | |
| uses: chromaui/action@v11 | |
| id: publish | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} | |
| # 👇 Chromatic projectToken, refer to the manage page to obtain it. | |
| projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} | |
| buildScriptName: build | |
| workingDir: ./common/storybook/ | |
| visual-regression: | |
| name: Visual regression tests | |
| runs-on: ubuntu-latest | |
| timeout-minutes: 30 | |
| container: | |
| image: mcr.microsoft.com/playwright:v1.45.0 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| browser: ['chromium', 'webkit'] | |
| shard: [1, 2, 3] | |
| env: | |
| SHARD_COUNT: '3' | |
| CYPRESS_INSTALL_BINARY: '0' | |
| NODE_OPTIONS: --max-old-space-size=6144 | |
| OPT_OUT_CAPTURE: 1 | |
| outputs: | |
| # The below have to be manually listed unfortunately, as GitHub Actions doesn't allow matrix-dependent outputs | |
| chromium-1-added: ${{ steps.diff.outputs.chromium-1-added }} | |
| chromium-1-modified: ${{ steps.diff.outputs.chromium-1-modified }} | |
| chromium-1-deleted: ${{ steps.diff.outputs.chromium-1-deleted }} | |
| chromium-1-total: ${{ steps.diff.outputs.chromium-1-total }} | |
| chromium-1-commitHash: ${{ steps.commit-hash.outputs.chromium-1-commitHash }} | |
| chromium-2-added: ${{ steps.diff.outputs.chromium-2-added }} | |
| chromium-2-modified: ${{ steps.diff.outputs.chromium-2-modified }} | |
| chromium-2-deleted: ${{ steps.diff.outputs.chromium-2-deleted }} | |
| chromium-2-total: ${{ steps.diff.outputs.chromium-2-total }} | |
| chromium-2-commitHash: ${{ steps.commit-hash.outputs.chromium-2-commitHash }} | |
| chromium-3-added: ${{ steps.diff.outputs.chromium-3-added }} | |
| chromium-3-modified: ${{ steps.diff.outputs.chromium-3-modified }} | |
| chromium-3-deleted: ${{ steps.diff.outputs.chromium-3-deleted }} | |
| chromium-3-total: ${{ steps.diff.outputs.chromium-3-total }} | |
| chromium-3-commitHash: ${{ steps.commit-hash.outputs.chromium-3-commitHash }} | |
| webkit-1-added: ${{ steps.diff.outputs.webkit-1-added }} | |
| webkit-1-modified: ${{ steps.diff.outputs.webkit-1-modified }} | |
| webkit-1-deleted: ${{ steps.diff.outputs.webkit-1-deleted }} | |
| webkit-1-total: ${{ steps.diff.outputs.webkit-1-total }} | |
| webkit-1-commitHash: ${{ steps.commit-hash.outputs.webkit-1-commitHash }} | |
| webkit-2-added: ${{ steps.diff.outputs.webkit-2-added }} | |
| webkit-2-modified: ${{ steps.diff.outputs.webkit-2-modified }} | |
| webkit-2-deleted: ${{ steps.diff.outputs.webkit-2-deleted }} | |
| webkit-2-total: ${{ steps.diff.outputs.webkit-2-total }} | |
| webkit-2-commitHash: ${{ steps.commit-hash.outputs.webkit-2-commitHash }} | |
| webkit-3-added: ${{ steps.diff.outputs.webkit-3-added }} | |
| webkit-3-modified: ${{ steps.diff.outputs.webkit-3-modified }} | |
| webkit-3-deleted: ${{ steps.diff.outputs.webkit-3-deleted }} | |
| webkit-3-total: ${{ steps.diff.outputs.webkit-3-total }} | |
| webkit-3-commitHash: ${{ steps.commit-hash.outputs.webkit-3-commitHash }} | |
| firefox-1-added: ${{ steps.diff.outputs.firefox-1-added }} | |
| firefox-1-modified: ${{ steps.diff.outputs.firefox-1-modified }} | |
| firefox-1-deleted: ${{ steps.diff.outputs.firefox-1-deleted }} | |
| firefox-1-total: ${{ steps.diff.outputs.firefox-1-total }} | |
| firefox-1-commitHash: ${{ steps.commit-hash.outputs.firefox-1-commitHash }} | |
| firefox-2-added: ${{ steps.diff.outputs.firefox-2-added }} | |
| firefox-2-modified: ${{ steps.diff.outputs.firefox-2-modified }} | |
| firefox-2-deleted: ${{ steps.diff.outputs.firefox-2-deleted }} | |
| firefox-2-total: ${{ steps.diff.outputs.firefox-2-total }} | |
| firefox-2-commitHash: ${{ steps.commit-hash.outputs.firefox-2-commitHash }} | |
| firefox-3-added: ${{ steps.diff.outputs.firefox-3-added }} | |
| firefox-3-modified: ${{ steps.diff.outputs.firefox-3-modified }} | |
| firefox-3-deleted: ${{ steps.diff.outputs.firefox-3-deleted }} | |
| firefox-3-total: ${{ steps.diff.outputs.firefox-3-total }} | |
| firefox-3-commitHash: ${{ steps.commit-hash.outputs.firefox-3-commitHash }} | |
| steps: | |
| - uses: actions/checkout@v3 | |
| with: | |
| fetch-depth: 1 | |
| repository: ${{ github.event.pull_request.head.repo.full_name }} | |
| ref: ${{ github.event.pull_request.head.ref }} | |
| # Use PostHog Bot token when not on forks to enable proper snapshot updating | |
| token: ${{ secrets.POSTHOG_BOT_GITHUB_TOKEN || github.token }} | |
| - name: Install pnpm | |
| uses: pnpm/action-setup@v4 | |
| - name: Set up Node.js | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: 18.12.1 | |
| cache: pnpm | |
| - name: Install package.json dependencies with pnpm | |
| run: pnpm --filter=@posthog/storybook... install --frozen-lockfile | |
| - name: Install CI utilities with pnpm | |
| run: pnpm install http-server wait-on -g | |
| - name: Build Storybook | |
| run: bin/turbo --filter=@posthog/storybook build | |
| - name: Serve Storybook in the background | |
| run: | | |
| retries=5 | |
| max_timeout=30 | |
| pnpm exec http-server common/storybook/dist --port 6006 --silent & | |
| server_pid=$! | |
| echo "Started http-server with PID: $server_pid" | |
| # Give the server a moment to start | |
| sleep 2 | |
| while [ $retries -gt 0 ]; do | |
| echo "Checking if Storybook is available (retries left: $retries, timeout: ${max_timeout}s)..." | |
| if pnpm wait-on http://127.0.0.1:6006 --timeout $max_timeout; then | |
| echo "✅ Storybook is available at http://127.0.0.1:6006" | |
| break | |
| fi | |
| retries=$((retries-1)) | |
| if [ $retries -gt 0 ]; then | |
| echo "⚠️ Failed to connect to Storybook, retrying... ($retries retries left)" | |
| # Check if server is still running | |
| if ! kill -0 $server_pid 2>/dev/null; then | |
| echo "❌ http-server process is no longer running, restarting it..." | |
| pnpm exec http-server common/storybook/dist --port 6006 --silent & | |
| server_pid=$! | |
| echo "Restarted http-server with PID: $server_pid" | |
| sleep 2 | |
| fi | |
| fi | |
| done | |
| if [ $retries -eq 0 ]; then | |
| echo "❌ Failed to serve Storybook after all retries" | |
| # Try to get some diagnostic information | |
| echo "Checking port 6006 status:" | |
| netstat -tuln | grep 6006 || echo "Port 6006 is not in use" | |
| echo "Checking http-server process:" | |
| ps aux | grep http-server || echo "No http-server process found" | |
| echo "Checking Storybook dist directory:" | |
| ls -la common/storybook/dist || echo "Storybook dist directory not found" | |
| exit 1 | |
| fi | |
| - name: Run @storybook/test-runner | |
| env: | |
| # Solving this bug by overriding $HOME: https://github.com/microsoft/playwright/issues/6500 | |
| HOME: /root | |
| # Update snapshots for PRs on the main repo, verify on forks, which don't have access to PostHog Bot | |
| VARIANT: ${{ github.event.pull_request.head.repo.full_name == github.repository && 'update' || 'verify' }} | |
| STORYBOOK_SKIP_TAGS: 'test-skip,test-skip-${{ matrix.browser }}' | |
| run: | | |
| pnpm --filter=@posthog/storybook test:visual:ci:$VARIANT --browsers ${{ matrix.browser }} --shard ${{ matrix.shard }}/$SHARD_COUNT | |
| - name: Archive failure screenshots | |
| if: ${{ failure() }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: failure-screenshots-${{ matrix.browser }}-${{ matrix.shard }} | |
| path: frontend/__snapshots__/__failures__/ | |
| - name: Configure global git diff log | |
| run: git config --global --add safe.directory '*' | |
| - name: Count and optimize updated snapshots | |
| id: diff | |
| # Skip on forks | |
| if: github.event.pull_request.head.repo.full_name == github.repository | |
| run: | | |
| echo "Current directory: $(pwd)" | |
| FRONTEND_DIFF_OUTPUT=$(git diff --name-status frontend/__snapshots__) | |
| echo "$FRONTEND_DIFF_OUTPUT" | |
| ADDED=$(git diff --name-status frontend/__snapshots__/ | grep '^A' | wc -l) | |
| MODIFIED=$(git diff --name-status frontend/__snapshots__/ | grep '^M' | wc -l) | |
| DELETED=$(git diff --name-status frontend/__snapshots__/ | grep '^D' | wc -l) | |
| TOTAL=$(git diff --name-status frontend/__snapshots__/ | wc -l) | |
| # If added or modified, run OptiPNG | |
| if [ $ADDED -gt 0 ] || [ $MODIFIED -gt 0 ]; then | |
| echo "Snapshots updated ($ADDED new, $MODIFIED changed), running OptiPNG" | |
| apt update && apt install -y optipng | |
| optipng -clobber -o4 -strip all | |
| # we don't want to _always_ run OptiPNG | |
| # so, we run it after checking for a diff | |
| # but, the files we diffed might then be changed by OptiPNG | |
| # and as a result they might no longer be different... | |
| # we check again | |
| git diff --name-status frontend/__snapshots__/ # For debugging | |
| ADDED=$(git diff --name-status frontend/__snapshots__/ | grep '^A' | wc -l) | |
| MODIFIED=$(git diff --name-status frontend/__snapshots__/ | grep '^M' | wc -l) | |
| DELETED=$(git diff --name-status frontend/__snapshots__/ | grep '^D' | wc -l) | |
| TOTAL=$(git diff --name-status frontend/__snapshots__/ | wc -l) | |
| if [ $ADDED -gt 0 ] || [ $MODIFIED -gt 0 ]; then | |
| echo "Snapshots updated ($ADDED new, $MODIFIED changed), _even after_ running OptiPNG" | |
| git add frontend/__snapshots__/ playwright/ | |
| fi | |
| fi | |
| echo "Snapshot changes:" | |
| echo "Added: $ADDED" | |
| echo "Modified: $MODIFIED" | |
| echo "Deleted: $DELETED" | |
| echo "Total: $TOTAL" | |
| echo "${{ matrix.browser }}-${{ matrix.shard }}-added=$ADDED" >> $GITHUB_OUTPUT | |
| echo "${{ matrix.browser }}-${{ matrix.shard }}-modified=$MODIFIED" >> $GITHUB_OUTPUT | |
| echo "${{ matrix.browser }}-${{ matrix.shard }}-deleted=$DELETED" >> $GITHUB_OUTPUT | |
| echo "${{ matrix.browser }}-${{ matrix.shard }}-total=$TOTAL" >> $GITHUB_OUTPUT | |
| - name: Commit updated snapshots | |
| uses: EndBug/add-and-commit@v9 | |
| if: github.event.pull_request.head.repo.full_name == github.repository | |
| id: commit | |
| with: | |
| add: '["frontend/__snapshots__/", "playwright/"]' | |
| message: 'Update UI snapshots for `${{ matrix.browser }}` (${{ matrix.shard }})' | |
| pull: --rebase --autostash # Make sure we're up to date with other browsers' updates | |
| default_author: github_actions | |
| github_token: ${{ secrets.POSTHOG_BOT_GITHUB_TOKEN || github.token }} | |
| - name: Add commit hash to outputs, including browser name | |
| id: commit-hash | |
| if: steps.commit.outputs.pushed == 'true' | |
| run: echo "${{ matrix.browser }}-${{ matrix.shard }}-commitHash=${{ steps.commit.outputs.commit_long_sha }}" >> $GITHUB_OUTPUT | |
| visual-regression-summary: | |
| name: Summarize visual regression tests | |
| runs-on: ubuntu-latest | |
| timeout-minutes: 5 | |
| needs: visual-regression | |
| # Run even if visual-regression fails for one (or more) of the browsers | |
| if: always() | |
| steps: | |
| - name: Post comment about updated snapshots | |
| if: github.event.pull_request.head.repo.full_name == github.repository | |
| uses: actions/github-script@v6 | |
| with: | |
| github-token: ${{ secrets.POSTHOG_BOT_GITHUB_TOKEN || github.token }} | |
| script: | | |
| const BROWSERS = ['chromium', 'webkit'] | |
| const diffJobOutputs = ${{ toJson(needs.visual-regression.outputs) }} | |
| const summaryDiff = { total: 0, added: 0, modified: 0, deleted: 0 } | |
| const diffByBrowser = Object.fromEntries(BROWSERS.map(browser => [browser, { | |
| total: 0, added: 0, modified: 0, deleted: 0, commitHashes: [] | |
| }])) | |
| for (const [key, rawValue] of Object.entries(diffJobOutputs)) { | |
| // Split e.g. 'chromium-1-commitHash' into ['chromium', '1' 'commitHash'] | |
| const [browser, shardNumber, diffKey] = key.split('-') | |
| // Sum up the counts - but not the commit hash | |
| if (diffKey === 'commitHash') { | |
| diffByBrowser[browser].commitHashes.push([parseInt(shardNumber), rawValue]) | |
| } else { | |
| const value = parseInt(rawValue) | |
| diffByBrowser[browser][diffKey] += value | |
| summaryDiff[diffKey] += value | |
| } | |
| } | |
| for (const browser of BROWSERS) { | |
| if (diffByBrowser[browser]?.total === undefined) { | |
| diffByBrowser[browser] = null // Null means failure | |
| } | |
| } | |
| if (summaryDiff.total === 0) { | |
| console.log('No changes were made, skipping comment') | |
| return | |
| } | |
| const diffByBrowserDisplay = Object.entries(diffByBrowser).map(([browser, diff]) => { | |
| if (!diff) { | |
| return `- \`${browser}\`: failed` | |
| } | |
| const { added: a, modified: m, deleted: d, commitHashes } = diff | |
| const b = a + m + d > 0 ? '**' : '' // Bold list item if there were changes | |
| let extraInfo = '' | |
| if (b) { | |
| const commitInfo = commitHashes.map( | |
| ([shardNumber, commitHash]) => | |
| `[diff for shard ${shardNumber}](https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}/commits/${commitHash})` | |
| ).join(', ') || "wasn't pushed!" | |
| extraInfo = ` (${commitInfo})` | |
| } | |
| return `- ${b}\`${browser}\`${b}: **${a}** added, **${m}** modified, **${d}** deleted${extraInfo}` | |
| }).join('\n') | |
| github.rest.issues.createComment({ | |
| issue_number: context.issue.number, | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| body: `## 📸 UI snapshots have been updated | |
| **${summaryDiff.total}** snapshot changes in total. **${summaryDiff.added}** added, **${summaryDiff.modified}** modified, **${summaryDiff.deleted}** deleted: | |
| ${diffByBrowserDisplay} | |
| Triggered by [this commit](https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}/commits/${{ github.sha }}). | |
| 👉 **[Review this PR's diff of snapshots.](https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}/files#:~:text=frontend/__snapshots__/)**` | |
| }) | |
| calculate-running-time: | |
| name: Calculate running time | |
| needs: [storybook-chromatic, visual-regression] | |
| runs-on: ubuntu-latest | |
| if: # Run on pull requests to PostHog/posthog + on PostHog/posthog outside of PRs - but never on forks | |
| ( | |
| github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name || github.repository | |
| ) == 'PostHog/posthog' | |
| steps: | |
| - name: Calculate running time | |
| run: | | |
| gh auth login --with-token < <(echo ${{ secrets.GITHUB_TOKEN }}) | |
| run_id=${GITHUB_RUN_ID} | |
| repo=${GITHUB_REPOSITORY} | |
| run_info=$(gh api repos/${repo}/actions/runs/${run_id}) | |
| echo run_info: ${run_info} | |
| # name is the name of the workflow file | |
| # run_started_at is the start time of the workflow | |
| # we want to get the number of seconds between the start time and now | |
| name=$(echo ${run_info} | jq -r '.name') | |
| run_url=$(echo ${run_info} | jq -r '.url') | |
| run_started_at=$(echo ${run_info} | jq -r '.run_started_at') | |
| run_attempt=$(echo ${run_info} | jq -r '.run_attempt') | |
| start_seconds=$(date -d "${run_started_at}" +%s) | |
| now_seconds=$(date +%s) | |
| duration=$((now_seconds-start_seconds)) | |
| echo running_time_duration_seconds=${duration} >> $GITHUB_ENV | |
| echo running_time_run_url=${run_url} >> $GITHUB_ENV | |
| echo running_time_run_attempt=${run_attempt} >> $GITHUB_ENV | |
| echo running_time_run_id=${run_id} >> $GITHUB_ENV | |
| echo running_time_run_started_at=${run_started_at} >> $GITHUB_ENV | |
| - name: Capture running time to PostHog | |
| uses: PostHog/[email protected] | |
| with: | |
| posthog-token: ${{secrets.POSTHOG_API_TOKEN}} | |
| event: 'posthog-ci-running-time' | |
| properties: '{"duration_seconds": ${{ env.running_time_duration_seconds }}, "run_url": "${{ env.running_time_run_url }}", "run_attempt": "${{ env.running_time_run_attempt }}", "run_id": "${{ env.running_time_run_id }}", "run_started_at": "${{ env.running_time_run_started_at }}"}' |