fix(trends): only filter breakdown values when needed (#21219)

PostHog · Mar 28, 2024 · 01ea124 · 01ea124
1 parent 703a4ec
commit 01ea124
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 34 deletions.
diff --git a/posthog/hogql_queries/insights/trends/breakdown.py b/posthog/hogql_queries/insights/trends/breakdown.py
@@ -126,6 +126,10 @@ def events_where_filter(self) -> ast.Expr | None:
                 right=ast.Constant(value=self.query.breakdownFilter.breakdown),
             )
 
+        # No need to filter if we're showing the "other" bucket, as we need to look at all events anyway.
+        if self.query.breakdownFilter is not None and not self.query.breakdownFilter.breakdown_hide_other_aggregation:
+            return ast.Constant(value=True)
+
         if (
             self.query.breakdownFilter is not None
             and self.query.breakdownFilter.breakdown is not None