feat(surveys): Add regex matching option #17738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
liyiy
reviewed
Oct 3, 2023
liyiy
reviewed
Oct 3, 2023
| <PureField label="URL targeting"> | ||
| <div className="flex flex-row gap-2 items-center"> | ||
| URL | ||
| <LemonSelect |
There was a problem hiding this comment.
This won't work for users unless they upgrade to latest posthog-js, so maybe we can include some sort of tooltip or message somewhere about it? 🤔
There was a problem hiding this comment.
Yeah makes sense, added message and validation
jurajmajerik
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Companion to PostHog/posthog-js#805 - that one should go in first.
Enables regex and exact matching on URL
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?