feat: configure session recording sample rate #18068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
reviewed
Oct 18, 2023
benjackwhite
approved these changes
Oct 19, 2023
benjackwhite
approved these changes
Oct 20, 2023
pauldambra
commented
Oct 21, 2023
| groupType: TaxonomicFilterGroupType.FeatureFlags, | ||
| value: value, | ||
| onChange: (_, __, item) => { | ||
| 'id' in item && item.id && onChange(item.id, item.key) |
There was a problem hiding this comment.
@liyiy @neilkakkar I've moved the flag selector into components since I wanted to use it in replay config. And exposed the flag key as well as the id on change... That ok?
benjackwhite
requested changes
Oct 23, 2023
frontend/src/scenes/session-recordings/settings/SessionRecordingSettings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/settings/SessionRecordingSettings.tsx
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/settings/SessionRecordingSettings.tsx
Outdated
Show resolved
Hide resolved
benjackwhite
approved these changes
Oct 24, 2023
| /> | ||
| </div> | ||
| <p> | ||
| Setting a minimum session duration will ensure that only sessions that last longer than that |
There was a problem hiding this comment.
I think we should warn that this does mean some useful data may not be collected. Debugging a user issue that starts with a loading screen before redirecting to another domain. With this setting set to say, 10 seconds, the initial redirect screen would not have been recorded as it is only buffered in memory.
There was a problem hiding this comment.
This could also be expanded in documentation instead of the modal
Justicea83
pushed a commit
to Justicea83/posthog
that referenced
this pull request
Oct 24, 2023
* feat: configure session recording sample rate * fix mock * Update query snapshots * Update query snapshots * Update query snapshots * fix * fix * Update query snapshots * fix * fix * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * Fix * fix * fix * add minimum duration setting * dropdown instead of text box * start adding linked flag * fix * fix * Update query snapshots * Update query snapshots * Update query snapshots * Update query snapshots * only return flag key in decide * doh * fix * Fix * don't have a restricted list of sample rates * fix * fix * Update query snapshots * all the options * review changes * Fix * fix --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow
This
This pairs nicely with PostHog/posthog-js#839