feat: for signup set make organization name optional and set a default one #21083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +401 B (0%) Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
xrdt
reviewed
Mar 22, 2024
xrdt
reviewed
Mar 22, 2024
frontend/src/scenes/authentication/signup/signupForm/signupLogic.ts
Outdated
Show resolved
Hide resolved
xrdt
approved these changes
Mar 22, 2024
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
I've made some changes since this was approved, so wanted to get another set of eyes. |
|
We should evaluate this in a few weeks and see how many orgs don't set a name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is making the organization name input for signup optional to reduce friction, it they don't enter one, it'll use
${first_name}'s Organization. They can always update it later if needed. I also added an event to track how many people don't enter an organization name.This PR also cleans up the first/last name usage to be more clear with consistent with other parts of the application.
Does this work well for both Cloud and self-hosted?
it doesn't have an impact
How did you test this code?
added e2e tests and unit tests