chore(web-analytics): Simplify channel type and reference docs #21196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
robbie-c
changed the title
robbie-c
force-pushed
the
update-channel-type-to-match-docs
branch
from
9515fc9 to
cb35cf0
Compare
robbie-c
commented
Mar 28, 2024
| @@ -68,14 +68,17 @@ def wrap_with_null_if_empty(expr: ast.Expr) -> ast.Expr: | |||
| args=[ast.Call(name="nullIf", args=[expr, ast.Constant(value="")]), ast.Constant(value="null")], | |||
| ) | |||
|
|
|||
| # This logic is referenced in our docs https://posthog.com/docs/data/channel-type, be sure to update both if you | |||
There was a problem hiding this comment.
Currently in PR PostHog/posthog.com#8150
mariusandra
approved these changes
Mar 28, 2024
robbie-c
force-pushed
the
update-channel-type-to-match-docs
branch
from
cb35cf0 to
cbdd7d3
Compare
Twixes
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
.*cp.*is a bit too general, and can give false positives given how high up in the ranking this rule is.Changes
Instead just list what we would expect to match
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
All existing tests pass