-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hog): sql nodes in repl #26084
feat(hog): sql nodes in repl #26084
Conversation
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
It looks like the code of |
2c6046c
to
641bc53
Compare
It looks like the code of |
641bc53
to
dc54dab
Compare
955fc9d
to
b0c26f4
Compare
It looks like the code of |
76a66c2
to
a36180f
Compare
Problem
Supersedes https://github.com/PostHog/posthog/pull/25040/files
Changes
Add support for SQL nodes into the Hog repl.
TODO
print(query)
is unusable now)sql((select..))
with double(
now)deserialize_hx_ast
is safe and works as intendedPrinting SQL in Python and comparing resultsnot todayPass the query to the backend as a printed string?keeping as an AST to make sure it just worksDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
WIP. See above. Still tests to write.