Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dashboards): remove remaining filters from dashboard templates #26836

Merged
merged 12 commits into from
Dec 13, 2024
Merged

refactor(dashboards): remove remaining filters from dashboard templates #26836

merged 12 commits into from
Dec 13, 2024

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Dec 11, 2024 •
edited
Loading

Problem

Follow up to #26389.

Changes

Removes remaining instances of filters in dashboard templates.

How did you test this code?

  • created a new team to test creation of the "DEFAULT_APP" dashboard
  • created a feature flag usage dashboard

@thmsobrmlr thmsobrmlr requested a review from a team December 12, 2024 10:00
Base automatically changed from convert-dashboard-templates to master December 13, 2024 11:45
@thmsobrmlr thmsobrmlr force-pushed the remove-filters-from-dashboard-templates-2 branch from e42105e to da4d134 Compare December 13, 2024 11:55
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) December 13, 2024 11:56
@thmsobrmlr thmsobrmlr merged commit 7e29106 into master Dec 13, 2024
89 checks passed
@thmsobrmlr thmsobrmlr deleted the remove-filters-from-dashboard-templates-2 branch December 13, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudhpillai anirudhpillai anirudhpillai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @anirudhpillai