Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): allow customizing result colors with data color themes #26862

Open
wants to merge 137 commits into
base: master
Choose a base branch
from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Dec 12, 2024

Problem

Users want to be able to customize the colors in insights. Most often this is because multiple insights on the same dashboard should have the same color for the same values. See #23093 and #17593. But there are other use cases as well:

The ability to control the themes and colours of insights and dashboards would be helpful to contextualise them to end users, eg Blue for B2B , green for B2C etc.

Changes

This PR is the unstacked version of #26238, #26296, #26350 & #26522, with a recent version of master merged in and some fixes.

Summary of changes:

Screenshot 2024-12-12 at 12 58 05 Screenshot 2024-12-12 at 12 58 37 Screenshot 2024-12-12 at 13 49 14 Screenshot 2024-12-13 at 17 15 02

How did you test this code?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

18 snapshot changes in total. 0 added, 18 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Size Change: +460 B (+0.04%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +460 B (+0.04%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants