refactor: Redshift batch export uses spmc consumer #26897
+362
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
changed the title
tomasfarias
force-pushed
the
refactor/redshift-batch-export-uses-spmc-consumer
branch
from
9e1e133 to
97bf04c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Redshift batch export is not using SPMC abstractions, instead it is doing its own thing. This leads to duplication and harder to read code. The main reason it wasn't migrated is that Redshift doesn't write to a file but instead to a query that then gets executed. We can still adapt the same abstractions as all other batch exports though, so that's what we do here.
Changes
BatchExportWriter:RedshiftInsertBatchExportWriter. This new writer will write INSERT queries for Redshift.RedshiftConsumerthat flushes these queries by executing them.run_consumer_loopis nowrun_consumeras we no longer run multiple in a loop, this may change later.run_consumernow takes an instance ofConsumerwhich simplifies the signature slightly.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?