Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no polling when hidden #26912

Merged
merged 2 commits into from
Dec 14, 2024
Merged

fix: no polling when hidden #26912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e67088
fix: no polling when hidden
pauldambra Dec 13, 2024
5c6dac2
fix
pauldambra Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cypress/e2e/insights-navigation-open-sql-insight-first.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ describe('Insights', () => {

it('can open a new stickiness insight', () => {
insight.clickTab('STICKINESS')
// this test flaps, so check for a parent element, that is present even when failing
// in the hope that it slows the test down a little and stops it flapping
cy.get('.InsightVizDisplay--type-stickiness').should('exist')
cy.get('.TrendsInsight canvas').should('exist')
})

Expand Down
9 changes: 8 additions & 1 deletion frontend/src/layout/navigation-3000/sidepanel/panels/activity/sidePanelActivityLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export const sidePanelActivityLogic = kea<sidePanelActivityLogicType>([
],
})),

listeners(({ values, actions }) => ({
listeners(({ values, actions, cache }) => ({
setActiveTab: ({ tab }) => {
if (tab === SidePanelActivityTab.All && !values.allActivityResponseLoading) {
actions.loadAllActivity()
Expand All @@ -191,6 +191,13 @@ export const sidePanelActivityLogic = kea<sidePanelActivityLogicType>([
actions.setActiveTab(options as SidePanelActivityTab)
}
},
togglePolling: ({ pageIsVisible }) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already called this... we just ignored it

if (pageIsVisible) {
actions.loadImportantChanges()
} else {
clearTimeout(cache.pollTimeout)
}
},
})),
selectors({
allActivity: [
Expand Down
Loading