Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remoteconfig session replay domains check #26924

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: Remoteconfig session replay domains check #26924

merged 2 commits into from
Dec 16, 2024
+45 −9

Conversation

benjackwhite
Copy link
Contributor

Problem

Noticed a slight bug in the logic

Changes

  • Removed the decide override which revealed the bug
  • Fixed the bug by checking that the domains list has entries

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

pauldambra
pauldambra approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benjackwhite benjackwhite enabled auto-merge (squash) December 16, 2024 09:50
@benjackwhite benjackwhite requested review from a team December 16, 2024 11:50
@benjackwhite benjackwhite merged commit ff77be5 into master Dec 16, 2024
89 checks passed
@benjackwhite benjackwhite deleted the fix/recording-domains branch December 16, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @pauldambra