feat: add access denied UI #27335
feat: add access denied UI #27335
Conversation
|
Size Change: +9 B (0%) Total Size: 1.13 MB ℹ️ View Unchanged
|
| @@ -449,6 +450,7 @@ export const featureFlagLogic = kea<featureFlagLogicType>([ | |||
| }, | |||
| }, | |||
| ], | |||
| accessDeniedToFeatureFlag: [false, { setAccessDeniedToFeatureFlag: () => true }], | |||
There was a problem hiding this comment.
Do any of these cause a flashed screen before the endpoint returns, or are they all covered by page loaders?
There was a problem hiding this comment.
Yeah a bit, def room to improve.
NotFound actually doesn't magically work (I thought it did too). I copied this pattern from NotFound because the request was too hard to intercept.
|
Yeah I mean this line though - auto detecting that there is a impersonation possibility. But I'm more thinking "later it would be good if we had a component you could use that intelligently understood common fetch outcomes". So not something for you but more for dev-ex |
| @@ -2742,7 +2742,7 @@ async function handleFetch(url: string, method: string, fetcher: () => Promise<R | |||
| error = e | |||
| } | |||
|
|
|||
| apiStatusLogic.findMounted()?.actions.onApiResponse(response, error) | |||
| apiStatusLogic.findMounted()?.actions.onApiResponse(response?.clone(), error) | |||
There was a problem hiding this comment.
This is needed because it calls resonse.json() so downstream functions can't pull out the body response.
Changes
Follow along on RBAC project here: #24512
This PR is waiting on: #27330
RBAC Access denied UI for supported resources: dashboards, insights, notebooks, feature flags. This will be loaded when the load resource request 403s. I looked at adding middleware to the API logic, but it was just too finicky and hard to determine when requests to intercept.
Note: this is not viewable by users yet because we aren't returning 403s yet unless they are using the new RBAC system.
Image will be updated, request here: PostHog/posthog.com#10285
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manually