Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm-observability): trace scene #27562

Merged
merged 17 commits into from
Jan 17, 2025
Merged

feat(llm-observability): trace scene #27562

merged 17 commits into from
Jan 17, 2025

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Jan 15, 2025

Problem

We want to have a view where generations are grouped in a single sorted list to debug the agent.

Changes

This PR adds a basic scene.

Demo

2025-01-16 14 59 24

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Manual testing + backend unit tests.

@skoob13 skoob13 requested review from Twixes and k11kirky January 16, 2025 16:14
@skoob13 skoob13 marked this pull request as ready for review January 16, 2025 16:14
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Size Change: +83 B (+0.01%)

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.13 MB +83 B (+0.01%)

compressed-size-action

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a couple commits to be able to test this better locally - most importantly self-capture of Max AI generation.
Looking good, just a few polishes I think are worth adding!

frontend/src/scenes/llm-observability/utils.ts Outdated Show resolved Hide resolved
import { llmObservabilityLogic } from './llmObservabilityLogic'
import type { llmObservabilityTraceLogicType } from './llmObservabilityTraceLogicType'

export interface LLMObservabilityTraceDataNodeLogicParams {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a really verbose name 🙈

@skoob13
Copy link
Contributor Author

skoob13 commented Jan 17, 2025

@Twixes updated screenshots:
Screenshot 2025-01-17 at 17 21 25
Screenshot 2025-01-17 at 17 21 54

@skoob13 skoob13 requested a review from Twixes January 17, 2025 16:26
@skoob13 skoob13 merged commit 6bc2ada into master Jan 17, 2025
99 checks passed
@skoob13 skoob13 deleted the feat/trace-scene branch January 17, 2025 19:16
zlwaterfield pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants