Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove empty session_id values from aggregated count #27650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jan 17, 2025

Problem

We see a ton of issues with large occurrence / user counts but the session count is 1 🤔

Screenshot 2025-01-17 at 15 42 44

We thought this was because NULL was being counted as a distinct value but CH docs confirm that NULL values are excluded from the count. Upon investigation it seems like the $session_id can sometimes be a blank string, which is a distinct value we want to exclude

Changes

  • Exclude empty string $session_id by casting them to NULL
  • Handle things nicely on the frontend with tooltips to explain what is going on

sessions

@daibhin daibhin requested a review from a team January 17, 2025 15:45
@daibhin daibhin changed the title remove empty session_id values from aggregated count fix: remove empty session_id values from aggregated count Jan 17, 2025
Copy link
Contributor

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.13 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant