fix: remove empty session_id values from aggregated count #27650
+129
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We see a ton of issues with large occurrence / user counts but the session count is 1 🤔
We thought this was because
NULL
was being counted as a distinct value but CH docs confirm that NULL values are excluded from the count. Upon investigation it seems like the$session_id
can sometimes be a blank string, which is a distinct value we want to excludeChanges
$session_id
by casting them to NULL