feat(select source sync time): Select source time of day anchor #29284
+269
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
…efore saved in database.
…e UI and add sync time of day test
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a feature allowing users to select the time of day for source data synchronization in the data warehouse.
- Added
sync_time_of_dayTimeField toExternalDataSchemamodel with migration 0677 - Implemented UI controls in
SchemaForm.tsxandSchemas.tsxto toggle between UTC/local time display - Added time selection functionality in source creation wizard via
sourceWizardLogic.tsx - Modified
service.pyto use calendar-based scheduling for frequencies over an hour, respecting the selected sync time - Added test case
test_update_schema_sync_time_of_dayto verify the API endpoint and workflow triggering
12 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
# Conflicts: # frontend/__snapshots__/replay-player-failure--recent-recordings-404--dark.png # frontend/__snapshots__/replay-player-failure--recent-recordings-404--light.png # frontend/__snapshots__/replay-player-success--recent-recordings--dark.png # frontend/__snapshots__/replay-player-success--recent-recordings--light.png # frontend/__snapshots__/replay-player-success--second-recording-in-list--dark.png # frontend/__snapshots__/replay-player-success--second-recording-in-list--light.png # posthog/migrations/max_migration.txt
|
Size Change: +312 B (0%) Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…' into feature(select-source-sync-time)
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…' into feature(select-source-sync-time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users cannot change the time of day that a source updates at. This PR introduces a change to temporal schedules to make them Calendar based iff the interval exceeds 1 hour.
There are some nuances here to consider. Our backend is storing the time in UTC and the time selected is the first time of the day in UTC that the schedule will run. We also do not have jitter for tasks that are scheduled at midnight UTC since we theoretically are distributing our load much better than before when a user selects a time of day manually.
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Temporal schedules updated, added unit test