fix: improved survey search #29372
Merged
fix: improved survey search #29372
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added ignoreLocation: true to the Fuse.js search configuration in surveysLogic to improve survey search functionality.
- Modified search behavior in
frontend/src/scenes/surveys/surveysLogic.tsxto match terms regardless of their position in survey names - Fixed issue where search terms in parentheses weren't being properly matched
- Maintained existing search threshold of 0.3 for fuzzy matching
- Kept the same search keys (
keyandname) for survey filtering
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
marandaneto
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix survey search to match terms in parentheses. Added ignoreLocation: true to Fuse.js config to ensure search finds terms regardless of their position in survey names
Changes
before:\
after:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
verified locally