fix(cdp): fixes broken dictonary property adding #29514
Merged
+9
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed a bug in the DictionaryField component that prevented users from adding additional dictionary properties in the CDP pipeline configuration.
- Added
prevFilteredEntriesRefusinguseRefinfrontend/src/scenes/pipeline/hogfunctions/HogFunctionInputs.tsxto properly track and compare previous entries - Improved deep comparison logic for array elements to prevent unnecessary re-renders
- Updated
useEffectdependencies to ensure proper propagation of changes to parent components
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
benjackwhite
reviewed
Mar 5, 2025
frontend/src/scenes/pipeline/hogfunctions/HogFunctionInputs.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 9.93 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
benjackwhite
approved these changes
Mar 5, 2025
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
meikelmosby
force-pushed
the
fix/cdp/fixes-saving-of-dict-props
branch
from
3be556d to
9e90083
Compare
adamleithp
pushed a commit
that referenced
this pull request
Mar 5, 2025
Co-authored-by: Ben White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
saving dictionary properties was broken as in one could not add additional properties.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?