This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
feat: Use new WebhookJobError struct for error reporting #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
changed the title
tomasfarias
commented
Dec 18, 2023
tomasfarias
force-pushed
the
feat/webhook-error
branch
from
bd886f1 to
a19b4b7
Compare
tomasfarias
changed the base branch from
refactor/add-metadata-field
to
main
tomasfarias
force-pushed
the
feat/webhook-error
branch
from
9c864b9 to
d80644b
Compare
tomasfarias
changed the base branch from
main
to
refactor/add-metadata-field
bretthoerner
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing errors just as strings, we should support the
app_metricserror schema and use a struct withtype,details, anduuidfields; a newWebhookJobErrorwas added to support this schema. Consumer now passes the new struct tofailandretrycalls. These methods were already implemented generically over anything that can be serialized to json, so no changes required from that side to support a struct instead ofString.TODO: Should the UUID have any meaning? I've included it mostly to support the
app_metricsschema, but I'm generating a new one on every error, so it's not very useful information (at least for now).